Skip to content

Do not exit with an error if lib is not present #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2019
Merged

Do not exit with an error if lib is not present #299

merged 1 commit into from
Jul 23, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 23, 2019

Cli doesn't fail anymore if a library scheduled for removal is not actually installed.

rsora
rsora approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(additional 👍 for removing also the unused function findLibrary)

@masci masci merged commit 00840b0 into master Jul 23, 2019
@masci masci deleted the massi/lib-remove branch July 23, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masci @rsora